-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix GPU JAR testing on Linux #27011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix GPU JAR testing on Linux #27011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes GPU JAR testing on Linux by ensuring the custom operations library is properly packaged in the testing JAR.
Changes:
- Updated GPU package configuration to include
libcustom_op_library.soin the testing JAR - Added debug output to the test script to verify test directory contents
- Improved shell script quoting for the classpath parameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/ci_build/github/windows/jar_packaging.py | Changed archive_lib flag from False to True for GPU Linux x64 to include libcustom_op_library.so in testing JAR |
| tools/ci_build/github/linux/java_linux_final_test.sh | Added ls command for debugging and quoted the --scan-classpath parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mavenVersionOption: 'Default' | ||
|
|
||
| - task: Bash@3 | ||
| displayName: 'Run Java Tests on Linux/macOS' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: change name since macOS is removed.
Description
Fix GPU JAR testing
Motivation and Context
Testing JAR for GPU was missing libcustom_library.so on Linux.